Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isEnabled from the config model interface #909

Merged
merged 1 commit into from May 3, 2020
Merged

Remove isEnabled from the config model interface #909

merged 1 commit into from May 3, 2020

Conversation

bogdandrutu
Copy link
Member

Fixes #347

@codecov-io
Copy link

codecov-io commented May 2, 2020 •
edited

Codecov Report

Merging #909 into master will decrease coverage by 0.15%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   85.12%   84.96%   -0.16%     
==========================================
  Files         174      174              
  Lines       13376    13341      -35     
==========================================
- Hits        11386    11335      -51     
- Misses       1543     1552       +9     
- Partials      447      454       +7
Impacted Files Coverage Δ
config/configmodels/configmodels.go 95.00% <ø> (-0.84%) ⬇️
config/example_factories.go 84.84% <ø> (+0.17%) ⬆️
receiver/jaegerreceiver/config.go 100.00% <ø> (ø)
receiver/otlpreceiver/factory.go 94.87% <ø> (-0.13%) ⬇️
receiver/jaegerreceiver/factory.go 93.38% <80.00%> (ø)
translator/trace/jaeger/traces_to_jaegerproto.go 79.75% <88.88%> (-0.06%) ⬇️
config/config.go 96.26% <89.47%> (-3.49%) ⬇️
translator/internaldata/resource_to_oc.go 76.47% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b2d65...91f7e35. Read the comment docs.

rghetia
rghetia approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor nits. otherwise LGTM.

config/configmodels/configmodels.go Outdated Show resolved Hide resolved
config/configmodels/configmodels.go Show resolved Hide resolved
@bogdandrutu
Remove isEnabled from the config model interface
0f81c0f 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this pull request May 3, 2020
Closed
dmitryax
dmitryax approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Don't have context why it was needed before tho.

@bogdandrutu bogdandrutu merged commit 5d1aacc into open-telemetry:master May 3, 2020
@bogdandrutu bogdandrutu deleted the disabled branch May 3, 2020 15:10
@pavolloffay pavolloffay mentioned this pull request May 4, 2020
Merged
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
@bogdandrutu @wyTrivail
Remove isEnabled from the config model interface (open-telemetry#909)
09b049b 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@matej-g @MrAlias
Add semantic convention for faas.coldstart and container.id (open…
5a4b68c 
…-telemetry#909)

* Add semantic convention for faas coldstart and container ID

* Update Changelog

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@rghetia rghetia rghetia approved these changes

@flands flands Awaiting requested review from flands

@owais owais Awaiting requested review from owais

@pjanotti pjanotti Awaiting requested review from pjanotti

@songy23 songy23 Awaiting requested review from songy23

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove disable/enable from components
4 participants
@bogdandrutu @codecov-io @dmitryax @rghetia