[component] deprecate component.UnmarshalConfig #9141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Dec 19, 2023
| @@ -27,12 +27,9 @@ var configValidatorType = reflect.TypeOf((*ConfigValidator)(nil)).Elem() | |||
| // UnmarshalConfig helper function to UnmarshalConfig a Config. | |||
| // It checks if the config implements confmap.Unmarshaler and uses that if available, | |||
| // otherwise uses Map.UnmarshalExact, erroring if a field is nonexistent. | |||
| // Deprecated: Use `conf.Unmarshal(cfg)` instead. | |||
There was a problem hiding this comment.
See the comment, and why this is needed
atoulme
force-pushed
the
deprecate_UnmarshalConfig
branch
from
9679f30
to
364e6f4
Compare
|
Indeed, that's not a good solution, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate component.UnmarshalConfig. Prefer
conf.Unmarshal(cfg)insteadThis PR also makes the
WithErrorUnused()option enabled by default.Link to tracking Issue:
Fixes #7102
Documentation:
Added deprecation information