[chore][config/configgrpc] Enable goleak check #9217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
force-pushed
the
goleak_configgrpc
branch
from
b008cc1
to
87a2107
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9217 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 340 340
Lines 17989 17989
=======================================
Hits 16253 16253
Misses 1412 1412
Partials 324 324 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Jan 4, 2024
Enables goleak to run on the configgrpc package. Requires ignoring the opencensus-go leak.
crobert-1
force-pushed
the
goleak_configgrpc
branch
from
87a2107
to
4783b9c
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables goleak to run on the configgrpc package. Requires ignoring the opencensus-go leak.
A few tests required an additional client connection close command to exit the client go routine. Additional information can be found here in the explanation for the method grpc.DialContext, specifically this comment:
configgrpc's method
ToClientConnis directly calling thegrpc.DialContextmethod referenced.Link to tracking Issue:
#9165
Testing:
Added goleak check is passing