Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config/configgrpc] introduce toListenerContext, deprecate toListener #9390

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 25, 2024

Description:
Introduce ToListenerContext and deprecate ToListener.

Link to tracking Issue:
#9389

@atoulme atoulme requested a review from a team as a code owner January 25, 2024 07:46
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b3b181) 90.23% compared to head (f359620) 90.23%.

Files Patch % Lines
config/configgrpc/configgrpc.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9390   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         345      345           
  Lines       18017    18019    +2     
=======================================
+ Hits        16257    16260    +3     
  Misses       1431     1431           
+ Partials      329      328    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 3cacd40 into open-telemetry:main Jan 25, 2024
31 of 32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants