[exporterhelper] Deprecate TimeoutSettings, use TimeoutConfig instead #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
timeoutsettings_timeoutconfig
branch
from
f43f9a4
to
3384725
Compare
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9391 +/- ##
==========================================
- Coverage 90.23% 90.19% -0.05%
==========================================
Files 345 345
Lines 18017 18025 +8
==========================================
Hits 16257 16257
- Misses 1431 1439 +8
Partials 329 329 ☔ View full report in Codecov by Sentry. |
atoulme
force-pushed
the
timeoutsettings_timeoutconfig
branch
from
3384725
to
a158f6e
Compare
atoulme
force-pushed
the
timeoutsettings_timeoutconfig
branch
from
a158f6e
to
9b400ab
Compare
atoulme
force-pushed
the
timeoutsettings_timeoutconfig
branch
from
896e5ad
to
748678c
Compare
|
Same as with #9393. I think there is no need to break the existing option for a function that will be replaced with another one |
|
Going to close for now, and we can always reopen if plans change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate TimeoutSettings, use TimeoutConfig instead
Link to tracking Issue:
#6767