[client] Fix race condition in Metadata.Get
#9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TylerHelmuth PTAL at the failing tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9595 +/- ##
==========================================
+ Coverage 90.69% 90.70% +0.01%
==========================================
Files 347 347
Lines 18211 18210 -1
==========================================
+ Hits 16516 16518 +2
+ Misses 1371 1369 -2
+ Partials 324 323 -1 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Feb 20, 2024
|
@jpkrohling please also take a look. |
bogdandrutu
approved these changes
Feb 21, 2024
bogdandrutu
reviewed
Feb 21, 2024
…elmuth/opentelemetry-collector into make-metadata-thread-safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where
Getwas not thread safe.Link to tracking Issue:
Closes #9594
Testing:
Tested locally