Stabilise TestGatherMetrics_EndToEnd #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
…cs have been generated, and gracefully handle getting repeat metrics
james-bebbington
force-pushed
the
hostmetrics-test-refactor
branch
from
b93bc9e
to
1547d15
Compare
|
Superseded by #952 |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
The code example was rendering oddly in github.com because the first line had 4 spaces instead of tabs like the rest of the example. Fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue:
#958
Description:
The
hostmetricsreceiver.TestGatherMetrics_EndToEndtest could intermittently fail if all metrics had not been generated after 80ms. This PR changes the test to userequire.Eventuallyand wait until we receive at least one set of all the expected metrics.Note #952 is also currently open which refactors the host metrics logic quite a lot so that there is only a single ticker running for this test, and we can terminate as soon as any metrics are received (see this line). If that PR is merged first, this PR doesn't need to be merged.