Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetExporters from component.Host #9987

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Remove the deprecated GetExporters function from component.Host

Link to tracking Issue:

Related to #7370

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner April 17, 2024 21:37
@TylerHelmuth
Copy link
Member Author

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (4f26784) to head (6eecd0c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9987      +/-   ##
==========================================
- Coverage   91.78%   91.67%   -0.12%     
==========================================
  Files         359      360       +1     
  Lines       16631    16641      +10     
==========================================
- Hits        15265    15255      -10     
- Misses       1040     1053      +13     
- Partials      326      333       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should

  1. Assert somewhere that the service implementation of component.Host still has this method.
  2. File an issue on the service 1.0 milestone tracker to remove this from the service implementation

@TylerHelmuth
Copy link
Member Author

File an issue on the service 1.0 milestone tracker to remove this from the service implementation

@mx-psi to avoid losing any context, I was planning to move #7370 from the component milestone to the service milestone once this is merged. I will add a not in that issue for what extra stuff needs done for service as part of delaying the work until then. Is that sufficient?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same issue works for me :)

service/host.go Show resolved Hide resolved
@mx-psi mx-psi merged commit 6611edf into open-telemetry:main Apr 22, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 22, 2024
@TylerHelmuth TylerHelmuth deleted the component-host-remove-getexporters branch April 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants