Initial folder layout to allow further commits #3
Conversation
Adjust .NET to C++ (correct copy-paste error of a similar dotnet document)
Co-authored-by: Reiley Yang <reyang@microsoft.com>
It's not that we have a huge line of maintainers in this repo at this point, so I mirrored what was done for OpenTelemetry .NET : listing same contributors and maintainers as for the main C++ repository. I'd be glad to be one of the maintainers. |
| help with reviews and code approval. However, as individual components are | ||
| developed by numerous contributors, approvers and maintainers are not expected | ||
| to directly contribute to every component. | ||
|
|
There was a problem hiding this comment.
Probably, we can bring more clarity ( in another PR ) on role of approvers and maintainers in PR review. I like the way it is done for opentelemetry-collector-contrib (https://github.com/open-telemetry/opentelemetry-collector-contrib):
News PRs will be automatically associated with the reviewers based on CODEOWNERS. PRs will be also automatically assigned to one of the maintainers or approvers for facilitation. The facilitator is responsible for helping the PR author and reviewers to make progress or if progress cannot be made for closing the PR.
There was a problem hiding this comment.
Let's do this in a follow-up PR
There was a problem hiding this comment.
I think we want to follow what folks are doing here https://github.com/open-telemetry/opentelemetry-dotnet-contrib#support.
I don't think we should assume the opentelemetry/cpp-maintainers and opentelemetry/cpp-approvers are the right group for this contrib repo.
There was a problem hiding this comment.
I removed the notion of opentelemetry/cpp-maintainers and opentelemetry/cpp-approvers, and added a reference to the CODEOWNERS process instead.
@reyang Can you look on this PR once, as it's blocked on changes requested by you. Thanks :) |
I'll approve if we remove https://github.com/orgs/open-telemetry/teams/cpp-maintainers and https://github.com/orgs/open-telemetry/teams/cpp-approvers from the PR. We can either create separate groups (e.g. cpp-contrib-approvers) like what .NET did, or leave it as a TODO for next PR. |
Remove notion of main repo contributors and maintainers
Clarify on CODEOWNER policy.
@reyang - I removed the notion of the main repo maintainers and approvers. I added a reference to the |
Initial folder layout to allow further commits. I intentionally left a few changes as
TBDto allow for additional flexibility:Different contributing individuals and companies should be able to use their own applicable coding style, i.e. if a module enables integration with a different system or product, it would most likely follow the coding style rules of the product.
I am not sure 100% re. the license, but keeping it Apache License Version 2.0 as the main repo. We may need to add an additional provision that optional community-contributed projects may each be under their own license?