Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert #1530

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Fix code scanning alert #1530

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0140de4
Fix code scanning alert
esigo Jul 30, 2022
c5c741d
Merge branch 'main' into scanning-alert
esigo Jul 30, 2022
e5fba1b
use unreachable ip
esigo Jul 30, 2022
4685d34
Merge branch 'scanning-alert' of https://github.com/esigo/opentelemet…
esigo Jul 30, 2022
b7c89d9
Merge branch 'main' into scanning-alert
lalitb Aug 1, 2022
ddcaf68
Merge branch 'main' into scanning-alert
esigo Aug 2, 2022
8de4450
fix CI
esigo Aug 3, 2022
b2d6a35
Merge branch 'main' into scanning-alert
esigo Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/test/http/curl_http_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ TEST_F(BasicCurlHttpTests, SendGetRequestSyncTimeout)
curl::HttpClientSync http_client;

http_client::Headers m1 = {};
auto result = http_client.Get("http://222.222.222.200:19000/get/", m1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why is the IP address changed? I think it is intended as some invalid/unreachable address. @lalitb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this address is invalid either

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some local app could listen on https://127.0.0.1:19000?

Copy link
Member

@lalitb lalitb Jul 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use the address from Documentation Address Block (https://datatracker.ietf.org/doc/html/rfc5737#section-4), as they are not allowed to be used on the public internet, and so would be always unreachable.

192.0.2.0 – 192.0.2.255
198.51.100.0 – 198.51.100.255
233.252.0.0 - 233.252.0.255

auto result = http_client.Get("https://192.0.2.0:19000/get/", m1);
EXPECT_EQ(result, false);

// When network is under proxy, it may connect success but closed by peer when send data
Expand Down Expand Up @@ -415,7 +415,7 @@ TEST_F(BasicCurlHttpTests, SendGetRequestAsyncTimeout)
std::shared_ptr<GetEventHandler> handlers[batch_count];
for (unsigned i = 0; i < batch_count; ++i)
{
sessions[i] = http_client.CreateSession("http://222.222.222.200:19000/get/");
sessions[i] = http_client.CreateSession("https://192.0.2.0:19000/get/");
auto request = sessions[i]->CreateRequest();
request->SetMethod(http_client::Method::Get);
request->SetUri("get/");
Expand Down