Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics warnings #1583

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Metrics warnings #1583

merged 2 commits into from
Aug 28, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Aug 28, 2022

Fixes Metrics warnings

Changes

removes unused variables.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team as a code owner August 28, 2022 18:14
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1583 (360ee03) into main (1f37839) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   85.02%   85.00%   -0.02%     
==========================================
  Files         156      156              
  Lines        4977     4977              
==========================================
- Hits         4231     4230       -1     
- Misses        746      747       +1
Impacted Files Coverage Δ
...dk/include/opentelemetry/sdk/metrics/instruments.h 0.00% <0.00%> (ø)
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

lalitb
lalitb approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@esigo esigo merged commit 5788287 into open-telemetry:main Aug 28, 2022
@esigo esigo deleted the metrics-warnings branch August 28, 2022 19:03
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
metrics warnings (open-telemetry#1583)
8428126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esigo @lalitb