Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix CI failures on Ubuntu 24.04 #2686

Merged
merged 3 commits into from
May 30, 2024
Merged

[CI] Fix CI failures on Ubuntu 24.04 #2686

merged 3 commits into from
May 30, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 30, 2024 •
edited
Loading

Fixes #2685

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb
Merge pull request #300 from open-telemetry/main
e4d4bd7 
[pull] main from open-telemetry:main
@lalitb
fix
05a8e64
@lalitb lalitb requested a review from a team as a code owner May 30, 2024 19:48
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (497eaf4) to head (052dd28).
Report is 70 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2686      +/-   ##
==========================================
+ Coverage   87.12%   87.70%   +0.58%     
==========================================
  Files         200      190      -10     
  Lines        6109     5849     -260     
==========================================
- Hits         5322     5129     -193     
+ Misses        787      720      -67

see 57 files with indirect coverage changes

marcalff
marcalff approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add comments pointing to the original issue:

so we know why needrestart is removed.

@marcalff marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label May 30, 2024
@marcalff marcalff changed the title Testing CI failure fix [CI] Fix CI failures on Ubuntu 24.04 May 30, 2024
@marcalff marcalff merged commit c5269cd into open-telemetry:main May 30, 2024
50 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 31, 2024
@malkia
Merge pull request #40 from open-telemetry/main
d83e3b0 
[CI] Fix CI failures on Ubuntu 24.04 (open-telemetry#2686)
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Github CI is unstable
3 participants
@lalitb @ThomsonTan @marcalff