Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-template propagator, Implement Global Propagator, no-op propagator #668

Merged
merged 12 commits into from
Apr 23, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Apr 9, 2021

Fixes #540

Changes

Please provide a brief description of the changes here.

  • In continuation with discussion in Add Global Propagator, Noop Propagator #644, remove the templatized propagator class, so that the propagator is not compiled against its carrier/target type, and the carrier/target type is instead passed as TextMapCarrier object in Inject() and Extract() functions. This further allows not to create global/composite propagator per carrier/target type. As an example, a global propagator once set, can be used to extract the context from (say) gRPC response, and pass the context to (say) HTTP request.

  • Provide an implementation of global and No-op propagator.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team as a code owner April 9, 2021 15:03
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #668 (3d40b82) into main (a978920) will increase coverage by 0.03%.
The diff coverage is 99.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   94.75%   94.78%   +0.03%     
==========================================
  Files         210      212       +2     
  Lines        9647     9707      +60     
==========================================
+ Hits         9141     9201      +60     
  Misses        506      506              
Impacted Files Coverage Δ
.../test/trace/propagation/jaeger_propagation_test.cc 97.91% <95.23%> (+0.09%) ⬆️
...de/opentelemetry/trace/propagation/b3_propagator.h 96.49% <100.00%> (ø)
...telemetry/trace/propagation/composite_propagator.h 100.00% <100.00%> (ø)
...pentelemetry/trace/propagation/global_propagator.h 100.00% <100.00%> (ø)
...entelemetry/trace/propagation/http_trace_context.h 93.44% <100.00%> (ø)
...i/include/opentelemetry/trace/propagation/jaeger.h 97.56% <100.00%> (ø)
.../opentelemetry/trace/propagation/noop_propagator.h 100.00% <100.00%> (ø)
api/test/trace/propagation/b3_propagation_test.cc 100.00% <100.00%> (ø)
...est/trace/propagation/composite_propagator_test.cc 100.00% <100.00%> (ø)
...pi/test/trace/propagation/http_text_format_test.cc 100.00% <100.00%> (ø)
... and 2 more

@lalitb lalitb changed the title Non-template propagator, Implement Global Propagator, No-op Propagator Non-template propagator, Implement Global Propagator, no-op propagator Apr 9, 2021
@lalitb lalitb merged commit f10acac into open-telemetry:main Apr 23, 2021
@lalitb lalitb mentioned this pull request May 5, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement global propagators
3 participants