[frontendproxy] - remove set-cookie #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
austinlparker
approved these changes
Dec 12, 2022
|
I think there's more cleanup here? Do we need to remove the env var set in the compose file as well? Also, just to make sure, the thing that's in-place now works at runtime not compile-time right? |
fatsheep9146
approved these changes
Dec 12, 2022
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
|
@austinlparker I removed the env var from docker-compose.yml. Is anything else missing? |
|
lgtm |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* remove set-cookie Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * remove unneeded env var Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In October we added code to the frontend proxy to set a cookie used by the frontend in order to specify the browser reachable otel-collector. This cookie is no longer used by the frontend, and we can safely remove it.
red diffs are the best diffs