Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix generate protobuf for TypeScript #640

Merged

Conversation

puckpuck
Copy link
Contributor

Previously make generate-protobuf only copied the demo.proto file but did not generate the protobuf classes required for IDEs to resolve imports. This adds the command to generate the protobuf classes.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team as a code owner December 15, 2022 02:18
@puckpuck puckpuck merged commit 7d8ba27 into open-telemetry:main Dec 16, 2022
@puckpuck puckpuck deleted the chore.fix_ts_generate-protobuf branch December 16, 2022 16:46
@julianocosta89
Copy link
Member

@puckpuck do we need an extra tool for this?
I keep getting:

Generating Typescript protobuf files for frontend
./node_modules/.bin/protoc-gen-ts_proto: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable
--ts_proto_out: protoc-gen-ts_proto: Plugin failed with status code 1.

I've tried installing https://www.npmjs.com/package/protoc-gen-ts, but it didn't solve.

@puckpuck
Copy link
Contributor Author

@julianocosta89 you need to run npm install in the src/frontend folder first.

I can add that to the gen proto script if you feel we should have it there as well.

@julianocosta89
Copy link
Member

@julianocosta89 you need to run npm install in the src/frontend folder first.

I can add that to the gen proto script if you feel we should have it there as well.

Either that or we could mention that step in the development doc

@puckpuck
Copy link
Contributor Author

Let’s go with doc updates. I’ll get a PR together shortly.

jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants