Add OTel java agent with JMX Metric Insights to kafka #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
mviitane
approved these changes
Dec 23, 2022
puckpuck
approved these changes
Dec 24, 2022
puckpuck
added
the
helm-update-required
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…#654) * Add otel agent with JMX metric insights to kafka Signed-off-by: svrnm <neumanns@cisco.com> * Increase memory limit for kafka * Remove pb files Signed-off-by: svrnm <neumanns@cisco.com> * Add docs for kafka service Signed-off-by: svrnm <neumanns@cisco.com> * Revert removal of demo.proto Signed-off-by: svrnm <neumanns@cisco.com> * Update CHANGELOG Signed-off-by: svrnm <neumanns@cisco.com> * Fix markdownlint error Signed-off-by: svrnm <neumanns@cisco.com> Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the java agent to the kafka broker. While this will not provide tracing, it will use JMX Metric Insights generate metrics and export them to prometheus:
Additional info
We plan to have a blog post about JMX Metric Insights on opentelemetry.io eventually, so calling out that the demo is making use of it would be a nice feature:-)
Merge Requirements
CHANGELOG.mdupdated to document new feature additions