Add exception.count in Runtime metrics (#431)

open-telemetry · Jun 23, 2022 · 76f0b06 · 76f0b06
1 parent d8d0e93
commit 76f0b06
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md
@@ -7,6 +7,8 @@
   ([#430](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/430))
 * Remove Process related metrics from .NET Runtime metrics
   ([#446](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/446))
+* Add `exception.count` in Runtime metrics
+  ([#431](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/431))
 
 ## 0.2.0-alpha.1
 

diff --git a/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetrics.cs b/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetrics.cs
@@ -89,6 +89,15 @@ public RuntimeMetrics(RuntimeMetricsOptions options)
             {
                 this.meter.CreateObservableGauge($"{metricPrefix}assembly.count", () => (long)AppDomain.CurrentDomain.GetAssemblies().Length, description: "Number of Assemblies Loaded.");
             }
+
+            if (options.IsExceptionCountEnabled)
+            {
+                var exceptionCounter = this.meter.CreateCounter<long>($"{metricPrefix}exception.count", description: "Number of exceptions thrown.");
+                AppDomain.CurrentDomain.FirstChanceException += (source, e) =>
+                {
+                    exceptionCounter.Add(1);
+                };
+            }
         }
 
         /// <inheritdoc/>

diff --git a/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetricsOptions.cs b/src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetricsOptions.cs
@@ -45,6 +45,11 @@ public class RuntimeMetricsOptions
         /// </summary>
         public bool? AssembliesEnabled { get; set; }
 
+        /// <summary>
+        /// Gets or sets a value indicating whether exception count metrics should be collected.
+        /// </summary>
+        public bool? ExceptionCountEnabled { get; set; }
+
         /// <summary>
         /// Gets a value indicating whether all metrics are enabled.
         /// </summary>
@@ -55,7 +60,8 @@ public class RuntimeMetricsOptions
 #if NETCOREAPP3_1_OR_GREATER
         && this.ThreadingEnabled == null
 #endif
-        && this.AssembliesEnabled == null;
+        && this.AssembliesEnabled == null
+        && this.ExceptionCountEnabled == null;
 
         /// <summary>
         /// Gets a value indicating whether garbage collection metrics is enabled.
@@ -80,5 +86,10 @@ public class RuntimeMetricsOptions
         /// Gets a value indicating whether assembly metrics is enabled.
         /// </summary>
         internal bool IsAssembliesEnabled => this.AssembliesEnabled == true || this.IsAllEnabled;
+
+        /// <summary>
+        /// Gets a value indicating whether exception count metrics is enabled.
+        /// </summary>
+        internal bool IsExceptionCountEnabled => this.ExceptionCountEnabled == true || this.IsAllEnabled;
     }
 }