Renaming property as suggested in review.

Fixing markdown linting errors.
open-telemetry · Jun 22, 2022 · e3ffced · e3ffced
1 parent 49e3b1c
commit e3ffced
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md
@@ -1,9 +1,11 @@
 # Changelog
 
 ## Unreleased
-* Added the EnrichActivityWithEvents option to StackExchangeRedisCallsInstrumentationOptions to be able to disable adding
-  ActivityEvents (Enqueued, Sent, ResponseReceived) for Redis commands to Activities since there is no way to clear these
-  after they have been added. This defaults to true to maintain current functionality.
+* Added the EnrichActivityWithTimingEvents option to
+  StackExchangeRedisCallsInstrumentationOptions to be able to disable adding
+  ActivityEvents (Enqueued, Sent, ResponseReceived) for Redis commands to
+  Activities since there is no way to clear these after they have been added.
+  This defaults to true to maintain current functionality.
 
 ## 1.0.0-rc9.5 (source code moved to contrib repo)
 

diff --git a/...nstrumentation.StackExchangeRedis/Implementation/RedisProfilerEntryToActivityConverter.cs b/...nstrumentation.StackExchangeRedis/Implementation/RedisProfilerEntryToActivityConverter.cs
@@ -164,7 +164,7 @@ public static Activity ProfilerCommandToActivity(Activity parentActivity, IProfi
                 var send = enqueued.Add(command.EnqueuedToSending);
                 var response = send.Add(command.SentToResponse);
 
-                if (options.EnrichActivityWithEvents)
+                if (options.EnrichActivityWithTimingEvents)
                 {
                     activity.AddEvent(new ActivityEvent("Enqueued", enqueued));
                     activity.AddEvent(new ActivityEvent("Sent", send));

diff --git a/...metry.Instrumentation.StackExchangeRedis/StackExchangeRedisCallsInstrumentationOptions.cs b/...metry.Instrumentation.StackExchangeRedis/StackExchangeRedisCallsInstrumentationOptions.cs
@@ -48,6 +48,6 @@ public class StackExchangeRedisCallsInstrumentationOptions
         /// <summary>
         /// Gets or sets a value indicating whether or not the <see cref="StackExchangeRedisCallsInstrumentation"/> should enrich Activity with <see cref="ActivityEvent"/> entries about the Redis command processing/lifetime. Defaults to <see cref="bool">true</see>.
         /// </summary>
-        public bool EnrichActivityWithEvents { get; set; } = true;
+        public bool EnrichActivityWithTimingEvents { get; set; } = true;
     }
 }