Don't mark Elasticsearch 404's as error (#368)

open-telemetry · May 20, 2022 · e708841 · e708841
1 parent 9a15e22
commit e708841
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/OpenTelemetry.Contrib.Shared/Api/SpanHelper.cs b/src/OpenTelemetry.Contrib.Shared/Api/SpanHelper.cs
@@ -34,6 +34,11 @@ public static Status ResolveSpanStatusForHttpStatusCode(int httpStatusCode)
                 return Status.Unset;
             }
 
+            if (httpStatusCode == 404)
+            {
+                return Status.Unset;
+            }
+
             return Status.Error;
         }
     }

diff --git a/src/OpenTelemetry.Instrumentation.ElasticsearchClient/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.ElasticsearchClient/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * Updated OTel SDK package version to 1.2.0
 * Update minimum full framework support to net462
+* Requests that get an HTTP status code of 404 are not marked as an error span status
 
 ## 1.0.0-beta.3