-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Hangfire instrumentation with OTel v1.6.0? #1500
Comments
In this case, you do not need to update .NET SDK/runtime. It should be safe to just upgrade IMO it should be fine to release package with older version if upgrading package will be not an option . @fred2u, what do you think? |
Theoretically, you are right. Practically, it means starting the dependency hell. We are trying to keep SDK, runtime, and packages versions aligned to make sure everything is compatible and tested together. Also, it's not only I'll open a corresponding issue in the main OTel repo to discuss this. In this issue, I only want to get the Hangfire release with a lower dependency version. I'll be happy to create a PR with a downgraded OTel version and another one to restore it. |
@gao-artur, please do it. I suppose that @fred2u will agree on this. Please remember about updating/reverting changelog. |
Relevant discussion in opentelemetry-dotnet repo. |
I would like to release Hangfire instrumentation to get these changes: #1440, #1442.
Unfortunately, this repo was already updated to use OTel v1.7.0 #1486.
And OTel v1.7.0 was updated to use
Microsoft.Extensions.*
packages v8.0.0. open-telemetry/opentelemetry-dotnet#5020 + open-telemetry/opentelemetry-dotnet#5015Unfortunately, we are not ready yet for .NET 8, and this dependency causes errors like this (we are using nuget CPM)
Is it possible to downgrade the
OpenTelemetry.Api.ProviderBuilderExtensions
dependency in Hangfire instrumentation to 1.6.0 to create a compatible release?And in general, this strategy of taking the latest versions of external packages sounds problematic to me. It leaves a lot of clients behind with old versions.
The text was updated successfully, but these errors were encountered: