Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenTelemetry SDK to 1.8.1 #1668

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 19, 2024

Fixes #.

Changes

Updates dependency to 1.8.1 version of core packages.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (71655ce) to head (57e52bf).
Report is 202 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   73.91%   69.94%   -3.98%     
==========================================
  Files         267      264       -3     
  Lines        9615     9871     +256     
==========================================
- Hits         7107     6904     -203     
- Misses       2508     2967     +459     
Flag Coverage Δ
unittests-Exporter.Geneva 48.58% <ø> (?)
unittests-Exporter.OneCollector 89.46% <ø> (?)
unittests-Extensions 83.33% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-ResourceDetectors.Azure 82.03% <ø> (?)
unittests-ResourceDetectors.Host 48.80% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 93.33% <ø> (?)
unittests-Solution 79.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 233 files with indirect coverage changes

@vishweshbankwar vishweshbankwar changed the title Upgrade core packages dependency Upgrade OpenTelemetry SDK to 1.8.1 Apr 19, 2024
@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 19, 2024 20:38
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner April 19, 2024 20:38
@@ -2,6 +2,9 @@

## Unreleased

* Updated OpenTelemetry SDK to 1.8.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we used "updated" or "update"? (it's inconsistent in this PR).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed it once more time. I think I have made in consistent within particular CHANGELOG.md file.

If you want to make in consistent across repository it deserves a separate task/PR. We have some level of incossitenty.

Merging as is, there is a request for release one package. It will be good to release it with 1.8.1 SDK.

@Kielek Kielek merged commit 448d9e2 into open-telemetry:main Apr 22, 2024
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet