Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollectorExporter] Resolve AOT warnings in OpenTelemetry.Exporter.OneCollector #1670

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

eerhardt
Copy link
Contributor

Changes

Make OpenTelemetry.Exporter.OneCollector compatible with native AOT.

  • Need to use the Microsoft.Extensions.Configuration.Binder source generator to solve 2 warnings. Need to reference the 8.0.1 version to get the latest updated to the source generator.
  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

….OneCollector

- Need to use the Microsoft.Extensions.Configuration.Binder source generator to solve 2 warnings. Need to reference the 8.0.1 version to get the latest updated to the source generator.
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (71655ce) to head (097308f).
Report is 199 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
+ Coverage   73.91%   74.24%   +0.33%     
==========================================
  Files         267      263       -4     
  Lines        9615     9961     +346     
==========================================
+ Hits         7107     7396     +289     
- Misses       2508     2565      +57     
Flag Coverage Δ
unittests-Exporter.Geneva 61.37% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 82.75% <ø> (?)
unittests-Instrumentation.AspNet 77.11% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 79.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lector/Internal/OneCollectorExporterEventSource.cs 42.85% <ø> (ø)

... and 210 files with indirect coverage changes

@CodeBlanch CodeBlanch added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Apr 19, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 4ffcf2f into open-telemetry:main Apr 19, 2024
120 checks passed
@eerhardt eerhardt deleted the OneCollectorAOT branch April 20, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants