-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.GrpcCore] Remove usage of "otel.status_code" and "otel.status_description" #1799
[Instrumentation.GrpcCore] Remove usage of "otel.status_code" and "otel.status_description" #1799
Conversation
@IliaBrahinets, could you please add CHANGELOG entry to document this? It might be important for some users. |
CHANGELOG has been updated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
+ Coverage 73.91% 80.17% +6.25%
==========================================
Files 267 116 -151
Lines 9615 3077 -6538
==========================================
- Hits 7107 2467 -4640
+ Misses 2508 610 -1898
Flags with carried forward coverage won't be shown. Click here to find out more. |
# Conflicts: # src/OpenTelemetry.Instrumentation.GrpcCore/CHANGELOG.md # src/OpenTelemetry.Instrumentation.GrpcCore/RpcScope.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging, as it is purely technical debt related to OTel SDK.
Related to open-telemetry/opentelemetry-dotnet#2569
Changes
SetStatus(ActivityStatusCode, desc)
from Activity instead ofSetStatus(StatusCode)
from ActivityExtensions