Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.GrpcCore] Remove usage of "otel.status_code" and "otel.status_description" #1799

Merged

Conversation

IliaBrahinets
Copy link
Member

Related to open-telemetry/opentelemetry-dotnet#2569

Changes

  • Remove usage of "otel.status_code" and "otel.status_description" from unit-tests
  • Use SetStatus(ActivityStatusCode, desc) from Activity instead of SetStatus(StatusCode) from ActivityExtensions

@IliaBrahinets IliaBrahinets requested a review from a team as a code owner May 14, 2024 18:57
@github-actions github-actions bot requested a review from pcwiese May 14, 2024 18:57
@Kielek Kielek added the comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore label May 15, 2024
@Kielek
Copy link
Contributor

Kielek commented May 15, 2024

@IliaBrahinets, could you please add CHANGELOG entry to document this?

It might be important for some users.

@IliaBrahinets
Copy link
Member Author

@IliaBrahinets, could you please add CHANGELOG entry to document this?

It might be important for some users.

CHANGELOG has been updated.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (71655ce) to head (f67bb79).
Report is 253 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   73.91%   80.17%   +6.25%     
==========================================
  Files         267      116     -151     
  Lines        9615     3077    -6538     
==========================================
- Hits         7107     2467    -4640     
+ Misses       2508      610    -1898     
Flag Coverage Δ
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 257 files with indirect coverage changes

# Conflicts:
#	src/OpenTelemetry.Instrumentation.GrpcCore/CHANGELOG.md
#	src/OpenTelemetry.Instrumentation.GrpcCore/RpcScope.cs
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging, as it is purely technical debt related to OTel SDK.

@Kielek Kielek merged commit 6687875 into open-telemetry:main May 20, 2024
39 checks passed
@IliaBrahinets IliaBrahinets deleted the remove-otel.status-attributes branch May 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants