-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Update BaggageActivityProcessor to use baggage key predicate #1816
base: main
Are you sure you want to change the base?
[Extensions] Update BaggageActivityProcessor to use baggage key predicate #1816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
===========================================
+ Coverage 73.91% 85.71% +11.79%
===========================================
Files 267 8 -259
Lines 9615 140 -9475
===========================================
- Hits 7107 120 -6987
+ Misses 2508 20 -2488
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-contrib into mike/baggage-predicate
…elemetry-dotnet-contrib into mike/baggage-predicate
Ping @open-telemetry/dotnet-contrib-approvers @open-telemetry/dotnet-contrib-maintainers - please can you take a look? |
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Thanks for the feedback @CodeBlanch - I've made some updates, please take another look. |
src/OpenTelemetry.Extensions/Internal/OpenTelemetryExtensionsEventSource.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
src/OpenTelemetry.Extensions/Internal/OpenTelemetryExtensionsEventSource.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/Internal/OpenTelemetryExtensionsEventSource.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Extensions.Tests/Trace/BaggageActivityProcessorTests.cs
Show resolved
Hide resolved
…elemetry-dotnet-contrib into mike/baggage-predicate
…-contrib into mike/baggage-predicate # Conflicts: # src/OpenTelemetry.Extensions/CHANGELOG.md
Fixes #1695
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes