Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Fix test dependency conflict #1889

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jun 14, 2024

Fixes build failures from #1888. Use pre-release versions consistently for all packages.

ref: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/9521755414/job/26249939293?pr=1888

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (71655ce) to head (879b474).
Report is 307 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   73.91%   65.19%   -8.73%     
==========================================
  Files         267       35     -232     
  Lines        9615     3660    -5955     
==========================================
- Hits         7107     2386    -4721     
+ Misses       2508     1274    -1234     
Flag Coverage Δ
unittests-Exporter.Geneva 65.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 249 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review June 14, 2024 20:43
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner June 14, 2024 20:43
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishweshbankwar vishweshbankwar merged commit c513d14 into open-telemetry:main Jun 14, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants