Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geneva Exporter - Set metric exporter temporality to delta #323

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Geneva Exporter - Set metric exporter temporality to delta #323

merged 3 commits into from
Apr 21, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Apr 21, 2022 •
edited
Loading

Ask for maintainers @open-telemetry/dotnet-maintainers

  • Release version 1.2.6 of the Geneva Exporter
  • Unlist version 1.2.5 of the Geneva Exporter from NuGet

@mic-max mic-max marked this pull request as ready for review April 21, 2022 19:33
@mic-max mic-max requested a review from a team as a code owner April 21, 2022 19:33
@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #323 (7de481c) into main (e07abb7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   24.29%   24.28%   -0.01%     
==========================================
  Files         121      121              
  Lines        3659     3660       +1     
==========================================
  Hits          889      889              
- Misses       2770     2771       +1
Impacted Files Coverage Δ
....Exporter.Geneva/GenevaMetricExporterExtensions.cs 0.00% <0.00%> (ø)

utpilla
utpilla approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

@cijothomas cijothomas merged commit c31851a into open-telemetry:main Apr 21, 2022
@cijothomas
Copy link
Member

Ask for maintainers @open-telemetry/dotnet-maintainers

  • Release version 1.2.6 of the Geneva Exporter
  • Unlist version 1.2.5 of the Geneva Exporter from NuGet

image
done.

@mic-max mic-max deleted the delta-temporality branch April 21, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@utpilla utpilla utpilla approved these changes

@CodeBlanch CodeBlanch Awaiting requested review from CodeBlanch

@reyang reyang Awaiting requested review from reyang

@Yun-Ting Yun-Ting Awaiting requested review from Yun-Ting

Assignees

@cijothomas cijothomas

@mic-max mic-max

@Yun-Ting Yun-Ting

@reyang reyang

@CodeBlanch CodeBlanch

@utpilla utpilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mic-max @cijothomas @utpilla @Yun-Ting @reyang @CodeBlanch