Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Add DI support for GenevaMetricExporter #397

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 6, 2022

Fixes #393

Changes

  • Add DI support for GenevaMetricExporter

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jun 6, 2022
@utpilla utpilla requested a review from a team as a code owner June 6, 2022 23:29
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry missing.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #397 (cbfb385) into main (e3abb7c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head cbfb385 differs from pull request most recent head 1a5814f. Consider uploading reports for the commit 1a5814f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   22.31%   22.29%   -0.03%     
==========================================
  Files         148      148              
  Lines        4561     4566       +5     
==========================================
  Hits         1018     1018              
- Misses       3543     3548       +5     
Impacted Files Coverage Δ
....Exporter.Geneva/GenevaMetricExporterExtensions.cs 0.00% <0.00%> (ø)

@utpilla utpilla merged commit 480440a into open-telemetry:main Jun 6, 2022
swetharavichandrancisco pushed a commit to swetharavichandrancisco/opentelemetry-dotnet-contrib that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Exporter.Geneva] Add DI support for GenevaMetricExporter
6 participants