[Instrumentation.StackExchangeRedis] StackExchangeRedis Instrumentation to leverage native Activity Status #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntelemetry-dotnet-contrib into yunl/activityStatus
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
- Coverage 77.76% 77.75% -0.01%
==========================================
Files 175 175
Lines 5261 5260 -1
==========================================
- Hits 4091 4090 -1
Misses 1170 1170
|
vishweshbankwar
approved these changes
Oct 11, 2022
utpilla
changed the title
|
Need changelog entry |
utpilla
added
the
comp:instrumentation.stackexchangeredis
cijothomas
reviewed
Oct 13, 2022
| @@ -107,8 +107,6 @@ public static Activity ProfilerCommandToActivity(Activity parentActivity, IProfi | |||
| // Total: | |||
| // command.ElapsedTime; // 00:00:32.4988020 | |||
|
|
|||
| activity.SetStatus(Status.Unset); | |||
There was a problem hiding this comment.
there was never a case where we set status to error?
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #707