Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.MySqlData] Fix analysis warnings #965

Merged
merged 2 commits into from Feb 22, 2023

Conversation

martincostello
Copy link
Contributor

Changes

Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.MySqlData.

Contributes to #950.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@48da125). Click here to learn what that means.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage        ?   68.66%           
=======================================
  Files           ?      199           
  Lines           ?     7595           
  Branches        ?        0           
=======================================
  Hits            ?     5215           
  Misses          ?     2380           
  Partials        ?        0           
Impacted Files Coverage Δ
...trumentation.MySqlData/MySqlDataInstrumentation.cs 77.47% <75.00%> (ø)

@martincostello martincostello force-pushed the issue-950-analysers-mysql branch 2 times, most recently from a079d17 to 0b62f29 Compare February 17, 2023 09:20
Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.MySqlData.
Contributes to open-telemetry#950.
@utpilla utpilla added the comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData label Feb 22, 2023
@utpilla utpilla merged commit 3ccf594 into open-telemetry:main Feb 22, 2023
@martincostello martincostello deleted the issue-950-analysers-mysql branch February 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants