[kafka] BUG - stop creating spans on empty reads #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
reviewed
Apr 10, 2024
RassK
reviewed
Apr 10, 2024
| activity.SetException(exception); | ||
| } | ||
| var activity = KafkaInstrumentation.StartConsumerActivity(consumeResult, (DateTimeOffset)state.StartTime!, instance!); | ||
| if (exception is not null) |
There was a problem hiding this comment.
may hide some transient network errors (since consumeResult has to exist) ... not sure if good or bad
There was a problem hiding this comment.
I'd leave it as is for the quick fix.
There was a problem hiding this comment.
Isn't that guaranteed by the check on line 40?
lachmatt
changed the title
pjanotti
approved these changes
Apr 11, 2024
pellared
approved these changes
Apr 11, 2024
nrcventura
approved these changes
Apr 11, 2024
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When
Consumeis called without timeout specified (e.g either withCancellationToken, or with no params), spans will be generated, by default, every 100ms (default value ofCancellationDelayMaxMsfromConsumerConfig).This results in great number of spans generated.
What
No longer create spans for empty reads.
Tests
Existing tests.
Checklist
CHANGELOG.mdis updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.