Merge branch 'main' into vibankwa/rename-instrumentationOptions

open-telemetry · Dec 1, 2023 · e17a5b8 · e17a5b8
2 parents 0971bbc + 94c20c6
commit e17a5b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md
@@ -23,6 +23,9 @@
   `HttpClientTraceInstrumentationOptions`.
   ([#5109](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5109))
 
+* **Breaking Change**: Removed `http.user_agent` tag from HttpClient activity.
+  ([#5110](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5110))
+
 ## 1.6.0-beta.3
 
 Released 2023-Nov-17

diff --git a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
@@ -167,15 +167,6 @@ public void OnStartActivity(Activity activity, object payload)
 
             activity.SetTag(SemanticConventions.AttributeUrlFull, HttpTagHelper.GetUriTagValueFromRequestUri(request.RequestUri));
 
-            if (request.Headers.TryGetValues("User-Agent", out var userAgentValues))
-            {
-                var userAgent = userAgentValues.FirstOrDefault();
-                if (!string.IsNullOrEmpty(userAgent))
-                {
-                    activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent);
-                }
-            }
-
             try
             {
                 this.options.EnrichWithHttpRequestMessage?.Invoke(activity, request);