Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin Exporter send service.namespace as Zipkin tag #1511

Closed
cijothomas opened this issue Nov 11, 2020 · 1 comment · Fixed by #1521
Closed

Zipkin Exporter send service.namespace as Zipkin tag #1511

cijothomas opened this issue Nov 11, 2020 · 1 comment · Fixed by #1521
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers
Milestone

Comments

@cijothomas
Copy link
Member

As per spec, service.namespace resource should be sent as a Zipkin tag, and not as service name.

Zipkin exporter currently concats the namespace with service name, and is not sending namespace as a Zipkin tag.
https://github.com/open-telemetry/opentelemetry-dotnet/blob/master/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs#L140-L142

@cijothomas cijothomas added bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers labels Nov 11, 2020
@eddynaka
Copy link
Contributor

For zipkin, we have two endpoints:

  1. localendpoint: the servicename is equal some name that you specified, for example, Zipkin Exporter
  2. remoteendpoint: the servicename is equal to the url.

If we switch to tags, what should be translated? the zipkiin exporter or the url?
And, when we convert to json, we have two properties, local and remote endpoint. Should we remove the servicename from those? If yes, RemoteEndpoint will be blank.

@cijothomas cijothomas added this to the 1.0.0-RC1 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants