Adding service.namespace as tags for zipkin #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
+ Coverage 81.27% 81.30% +0.02%
==========================================
Files 232 232
Lines 6311 6305 -6
==========================================
- Hits 5129 5126 -3
+ Misses 1182 1179 -3
|
updating changelog updating changelog updating changelog Revert "Adding service.namespace as tags for zipkin" This reverts commit 1868e71b964fa030bc33ece441047b19fa221688. updating file and changelog
cijothomas
approved these changes
Nov 12, 2020
CodeBlanch
reviewed
Nov 13, 2020
| @@ -119,9 +118,6 @@ internal void SetLocalEndpointFromResource(Resource resource) | |||
| case Resource.ServiceNameKey: | |||
| serviceName = label.Value as string; | |||
| continue; | |||
| case Resource.ServiceNamespaceKey: | |||
There was a problem hiding this comment.
@eddynaka FYI same logic exists in JaegerExporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1511.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes