Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hasdParent from SpanData #17

Closed
SergeyKanzhelev opened this issue May 10, 2019 · 5 comments
Closed

Remove hasdParent from SpanData #17

SergeyKanzhelev opened this issue May 10, 2019 · 5 comments
Assignees
@trwegner
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@SergeyKanzhelev
Copy link
Member

open-telemetry/opentelemetry-java#90
@SergeyKanzhelev SergeyKanzhelev added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label May 10, 2019
@trwegner
Copy link
Contributor

Working on this

@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone May 28, 2019
@trwegner
Copy link
Contributor

Would like to clarify if this change extends to all occurences of hasRemoteParent or actually just those in SpanData. Referencing the Java implementation, the concept of a remote parent appears to be addressed by use of SpanContext to specifiy a parent. To strictly follow this pattern, the changes extend well beyond SpanData.

@SergeyKanzhelev
Copy link
Member Author

I believe the concept of separate variable to track the informaiton on whether the parent is remote or now was removed all together. Including proto files.

@SergeyKanzhelev
Copy link
Member Author

SpanContext was always used to indicate the parent. hasRemoteParent gave additional information that parent is NOT local, meaning from the different process. Mostly used to indicate that clock may be un-synchronized

@trwegner trwegner mentioned this issue May 31, 2019
Merged
@SergeyKanzhelev
Copy link
Member Author

fixed via #55

Yun-Ting referenced this issue in Yun-Ting/opentelemetry-dotnet Oct 13, 2022
@eddynaka
::# This is a combination of 3 commits. (#17)
4e2ab19 
Adding missing extensions

Adding some tests

updating comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwegner trwegner

Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trwegner @SergeyKanzhelev