Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ASP.NET Core metrics instrumentation attribute compliance #3083

Closed
CodeBlanch opened this issue Mar 23, 2022 · 1 comment · Fixed by #3247
Closed

Improve ASP.NET Core metrics instrumentation attribute compliance #3083

CodeBlanch opened this issue Mar 23, 2022 · 1 comment · Fixed by #3247
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related

Comments

@CodeBlanch
Copy link
Member

Today our AspNetCore metrics instrumentation captures a small subset...

opentelemetry-dotnet/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

Lines 58 to 61 in 96b043e

{ SemanticConventions.AttributeHttpMethod, context.Request.Method },
{ SemanticConventions.AttributeHttpScheme, context.Request.Scheme },
{ SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode },
{ SemanticConventions.AttributeHttpFlavor, context.Request.Protocol },

...of the attributes defined in the spec semantic conventions. Notably http.target (route template) and http.host are missing which are probably high-value/nice-to-have.

If anyone would like to take this on I am available to provide guidance.

Relates to #1269
@CodeBlanch CodeBlanch added enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers metrics Metrics signal related labels Mar 23, 2022
@cijothomas
Copy link
Member

#2994 related

@vishweshbankwar vishweshbankwar mentioned this issue May 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional tags to ASP.NET Core metrics vishweshbankwar/opentelemetry-dotnet
2 participants
@cijothomas @CodeBlanch