Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What release is #3521 merged into? #3773

Closed
m-standfuss opened this issue Oct 17, 2022 · 2 comments
Closed

What release is #3521 merged into? #3773

m-standfuss opened this issue Oct 17, 2022 · 2 comments
Labels
question Further information is requested

Comments

@m-standfuss
Copy link

Question

Hi, we are trying to use the prometheus exporter option for open telemetry.

Our code currently looks like:

.AddPrometheusExporter(opt =>
{
    opt.StartHttpListener = true;
    opt.HttpListenerPrefixes = new string[] { $"{prometheusPrefix}:{prometheusPort}" };
    opt.ScrapeResponseCacheDurationMilliseconds = 0;
    opt.ScrapeEndpointPath = prometheusPath;
})

Which works fine for local development as it defaults to localhost. But when we pushed it out to our environment and attempted to scrape these metrics from another pod in our k8s cluster (with all the networking/ports setup to allow the traffic) it didnt work due to the HttpListenerPrefix being set to localhost. We updated it to include a wildcard but are hitting the issue which I believe is fixed due by the #3521 PR. It shows that commit as being tagged with the rc9.5 release.
image

But also is showing tagged as 1.4.0-beta.2:
image

Trying to determine which release its in so we can know if we need to implement the workaround or not
#2840 (comment)

Thanks,
Mike

Use Github Discussions.

@m-standfuss m-standfuss added the question Further information is requested label Oct 17, 2022
@utpilla
Copy link
Contributor

utpilla commented Oct 18, 2022

@m-standfuss This fix is available starting 1.4.0-alpha.2 version of the OpenTelemetry.Exporter.Prometheus.HttpListener package.

https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md#140-alpha2

You could use any version of the package which is >= 1.4.0-alpha.2.

@m-standfuss
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants