Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticConventions attribute name constants differ from spec #4101

Open
tshowers-bt opened this issue Jan 24, 2023 · 3 comments
Open

SemanticConventions attribute name constants differ from spec #4101

tshowers-bt opened this issue Jan 24, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@tshowers-bt
Copy link

Bug Report

OpenTelemetry.SemanticConventions 1.0.0-rc9.9

Symptom

I notice that some of the constants in the package don't match the values in the spec; for example public const string AttributeMessagingMessageId = "messaging.message_id"; but the spec refers to messaging.message.id.

The PR that introduced this says the values were autogenerated so maybe it's just out of date? I had a quick look at the build-tools and it links to the java package which has a constant that does match the spec.

@tshowers-bt tshowers-bt added the bug Something isn't working label Jan 24, 2023
@Kielek
Copy link
Contributor

Kielek commented Jan 24, 2023

@tshowers-bt
Copy link
Author

I'll certainly have a go at it. Probably later today.

@ttd2089
Copy link

ttd2089 commented Jan 27, 2023

I opened a PR but simply updating the versions didn't work. I found this issue and had to add a volume mount to the docker run command to fix the problem; but now I'm not sure whether the generated output is actually correct. As mentioned in the PR there are some properties in the generated code that I didn't see in the corresponding diff in the semconv changelog:

  • code.column
  • messaging.source.kind
  • messaging.source.template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants