feat: generate semconv v1.17.0 #4102
Conversation
Generates SemanticConventions from the v1.17.0 schemas. There is an open issue in the generator that caused mounting subfolders during the `docker run` steps to fail due to exception.yaml being absent -- mounting that file explicitly made the error go away but it's not clear whether that produces the desired code or just runs without an error. There are at least a few changes in the generated source that don't appear when in the spec changelog when comparing v1.13.0 to v.1.17.0: - code.column - messaging.source.kind - messaging.source.template
| @@ -3,9 +3,9 @@ $SCRIPT_DIR=$PSScriptRoot | |||
| $ROOT_DIR="${SCRIPT_DIR}/../../" | |||
There was a problem hiding this comment.
There is also .sh script in the same folder. It should be modified in the same way.
| $SCHEMA_URL="https://opentelemetry.io/schemas/$SPEC_VERSION" | ||
| $GENERATOR_VERSION="0.14.0" | ||
| $GENERATOR_VERSION="0.15.0" |
There was a problem hiding this comment.
I see also 0.15.1 version. Does it fix mentioned issue?
There was a problem hiding this comment.
I believe I tried both but I'll double check.
There was a problem hiding this comment.
Yea I get the same error with 0.14, 0.15, and 0.15.1; but I updated to 0.15.1 anyway.
Updates the generator version to 0.15.1 and replicates the updates into the generate.sh script. This doesn't fix the need for the extra volume mount but it's still not clear whether that's a workaround or just something that's required now.
|
@ttd2089 Could you update the public api files, given there are new conventions now. Also add an entry to changelog to indicate the new version. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Generates SemanticConventions from the v1.17.0 schemas.
Fixes #4101
There is an open issue in the generator that caused mounting subfolders during the
docker runsteps to fail due to exception.yaml being absent. Mounting that file explicitly made the error go away but it's not clear whether that produces the desired code or just runs without an error. There are at least a few changes in the generated source that don't appear when in the spec changelog when comparing v1.13.0 to v.1.17.0:I'm going to take a closer look at this tomorrow but I figured I'd open the PR for visibility anyway in case someone else can make sense of the differences more quickly than I can.