-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit naming of API and SDK packages #49
Comments
I believe keeping Abstractions is pretty consistent with .NET practices (Microsoft ships a lot of packages named like |
Idiomatic language practices are good, but what worries me is that we'll end up polluting |
For me it was a bit confusing at first, not finding the "Api" and "Sdk" layers anywhere. Also "Api" and "Sdk" terms come up in conversations sometimes and it's a bit weird to not have them reflected in the project names. However, no strong opinion on this. It's good to be idiomatic to a tech. Concerning "Abstractions": Which interfaces is it supposed to hold exactly?
Currently, all the above I would guess. Would it make sense to split out 1. into an "Api" project with minimal API surface? |
I have the same reservations about |
We discussed naming in #5. We may need to revisit it:
Abstraction
package have only a subset of classes and interfaces used in SDK. So not really an abstraction. Perhaps rename it toApi
instead for consistency with Java?OpenTelemetry
toOpenTelemetry.Sdk
? It will be consistent with Java. But harder for end user to follow the success path of "import OpenTelemetry" and you all set.Let's discuss naming here
The text was updated successfully, but these errors were encountered: