-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MeterProviderBuilder #1149
Merged
cijothomas
merged 2 commits into
open-telemetry:master
from
eddynaka:feature/adding-meterproviderbuilder
Aug 27, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // <copyright file="MeterProviderBuilder.cs" company="OpenTelemetry Authors"> | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Threading; | ||
| using OpenTelemetry.Metrics.Export; | ||
| using static OpenTelemetry.Metrics.MeterProviderSdk; | ||
|
|
||
| namespace OpenTelemetry.Metrics | ||
| { | ||
| /// <summary> | ||
| /// Build MeterProvider with Exporter, Processor and PushInterval. | ||
| /// </summary> | ||
| public class MeterProviderBuilder | ||
| { | ||
| private static readonly TimeSpan DefaultPushInterval = TimeSpan.FromSeconds(60); | ||
| private MetricProcessor metricProcessor; | ||
| private MetricExporter metricExporter; | ||
| private TimeSpan metricPushInterval; | ||
|
|
||
| internal MeterProviderBuilder() | ||
| { | ||
| this.metricExporter = new NoopMetricExporter(); | ||
| this.metricProcessor = new NoopMetricProcessor(); | ||
| this.metricPushInterval = DefaultPushInterval; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Sets processor. | ||
| /// </summary> | ||
| /// <param name="processor">Processor instance.</param> | ||
| /// <returns>Returns <see cref="MeterProviderBuilder"/> for chaining.</returns> | ||
| public MeterProviderBuilder SetProcessor(MetricProcessor processor) | ||
| { | ||
| this.metricProcessor = processor ?? new NoopMetricProcessor(); | ||
| return this; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Sets exporter. | ||
| /// </summary> | ||
| /// <param name="exporter">Exporter instance.</param> | ||
| /// <returns>Returns <see cref="MeterProviderBuilder"/> for chaining.</returns> | ||
| public MeterProviderBuilder SetExporter(MetricExporter exporter) | ||
| { | ||
| this.metricExporter = exporter ?? new NoopMetricExporter(); | ||
| return this; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Sets push interval. | ||
| /// </summary> | ||
| /// <param name="pushInterval">Push interval.</param> | ||
| /// <returns>Returns <see cref="MeterProviderBuilder"/> for chaining.</returns> | ||
| public MeterProviderBuilder SetPushInterval(TimeSpan pushInterval) | ||
| { | ||
| this.metricPushInterval = pushInterval == default ? DefaultPushInterval : pushInterval; | ||
| return this; | ||
| } | ||
|
|
||
| public MeterProvider Build() | ||
| { | ||
| var cancellationTokenSource = new CancellationTokenSource(); | ||
| var meterRegistry = new Dictionary<MeterRegistryKey, MeterSdk>(); | ||
|
|
||
| var controller = new PushMetricController( | ||
| meterRegistry, | ||
| this.metricProcessor, | ||
| this.metricExporter, | ||
| this.metricPushInterval, | ||
| cancellationTokenSource); | ||
|
|
||
| return new MeterProviderSdk(this.metricProcessor, meterRegistry, controller, cancellationTokenSource); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cijothomas do we want this to be
SetorAdd?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we allow multiple Processor, then Add. Else Set.
This decision is not clear, so I'll leave it as is until we actually implement Metric Sdk.
(This PR just make consistent pattern as Tracer only - Sdk.CreateMeterBuilder().accumulate_stuff_for_building().Build pattern)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that, thanks.