Remove tags added by gRPC library in favor of OpenTelemetry tags #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
commented
Sep 10, 2020
Comment on lines
-255
to
-258
| // TODO: Should the leading slash be trimmed? Spec seems to suggest no leading slash: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md#span-name | ||
| // Client instrumentation is trimming the leading slash. Whatever we decide here, should we apply the same to the client side? | ||
| // activity.DisplayName = grpcMethod?.Trim('/'); |
There was a problem hiding this comment.
I'd forgotten to resolve this when I originally did the work on this. The spec seems to indicate that the name not lead with a /, but the ASP.NET Core instrumentation sets the name appropriately already, though has a leading /. My take is that we just leave it this way. Unless others feel the spec clearly indicates that this / should not be in the name. https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md#span-name
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
+ Coverage 79.07% 79.13% +0.06%
==========================================
Files 215 215
Lines 6170 6174 +4
==========================================
+ Hits 4879 4886 +7
+ Misses 1291 1288 -3
|
cijothomas
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1021.
CHANGELOG.mdupdated for non-trivial changes