Conform gRPC span name to spec #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Nov 16, 2020
CodeBlanch
reviewed
Nov 16, 2020
| // The RPC semantic conventions indicate the span name | ||
| // should not have a leading forward slash. | ||
| // https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md#span-name | ||
| activity.DisplayName = grpcMethod.Trim('/'); |
There was a problem hiding this comment.
TrimStart might be slightly faster (if we're only concerned with the leading character).
There was a problem hiding this comment.
Good idea. Trimming only leading character should be ok in this context since grpcMethod is really just derived from the HttpContext.Request.Path.
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
==========================================
- Coverage 80.99% 80.93% -0.06%
==========================================
Files 236 236
Lines 6425 6426 +1
==========================================
- Hits 5204 5201 -3
- Misses 1221 1225 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes