Update the data type of OtlpExporter option Endpoint to string #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1786 +/- ##
=======================================
Coverage 83.89% 83.89%
=======================================
Files 187 187
Lines 5956 5956
=======================================
Hits 4997 4997
Misses 959 959
|
cijothomas
reviewed
Feb 4, 2021
| @@ -32,9 +32,9 @@ public class OtlpExporterOptions | |||
| #if NETSTANDARD2_1 | |||
| /// <summary> | |||
| /// Gets or sets the target to which the exporter is going to send traces or metrics. | |||
| /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md. | |||
| /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md. The endpoint value should start with http or https. | |||
There was a problem hiding this comment.
The link to valid syntax is not really applicable for NET2_1, right?
There was a problem hiding this comment.
that is correct. That naming is for gRPC Core only I think.
|
Closing this PR as this was fixed in #1789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #1778
Changes
CHANGELOG.mdupdated for non-trivial changes