Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Grocery Example for Metrics API #1831

Closed
wants to merge 22 commits into from

Conversation

victlu
Copy link
Contributor

@victlu victlu commented Feb 11, 2021

Create Grocery example per Metrics API SIG.

@victlu victlu requested a review from a team as a code owner February 11, 2021 22:11
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1831 (6e6ff21) into metrics (c8d8b8c) will increase coverage by 1.36%.
The diff coverage is n/a.

❗ Current head 6e6ff21 differs from pull request most recent head 7e7306b. Consider uploading reports for the commit 7e7306b to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #1831      +/-   ##
===========================================
+ Coverage    82.54%   83.91%   +1.36%     
===========================================
  Files          205      192      -13     
  Lines         6461     6184     -277     
===========================================
- Hits          5333     5189     -144     
+ Misses        1128      995     -133     
Impacted Files Coverage Δ
src/System.Diagnostics.Metrics.Temp/Measurement.cs
src/OpenTelemetry/Metrics/MeterProvider.cs
src/System.Diagnostics.Metrics.Temp/Counter.cs
...m.Diagnostics.Metrics.Temp/ObservableInstrument.cs
...iagnostics.Metrics.Temp/ObservableUpDownCounter.cs
src/System.Diagnostics.Metrics.Temp/InstrumentT.cs
...System.Diagnostics.Metrics.Temp/ObservableGauge.cs
...stem.Diagnostics.Metrics.Temp/ObservableCounter.cs
...c/OpenTelemetry/Metrics/MeterProviderBuilderSdk.cs
...c/System.Diagnostics.Metrics.Temp/MeterListener.cs
... and 3 more

@victlu
Copy link
Contributor Author

victlu commented Apr 12, 2021

Ping to see if we should approve this?

@reyang
Copy link
Member

reyang commented Apr 12, 2021

Ping to see if we should approve this?

I cannot approve this PR. I think the goal is to experiment + discuss this during the metrics API/SDK design, rather than ship code to the metrics branch at this phase.

@victlu victlu closed this May 5, 2021
@victlu victlu deleted the branch open-telemetry:metrics May 5, 2021 16:54
@victlu victlu deleted the metrics branch May 5, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants