Update AddHttpClientInstrumentation for .NET Framework

[utpilla]

Currently, AddHttpClientInstrumentation extension method for .NET Framework uses both HttpClientInstrumentationOptions and HttpWebRequestInstrumentationOptions as arguments. This causes confusion to a lot of users who want to configure the HttpWebRequestInstrumentationOptions but end up configuring HttpClientInstrumentationOptions as that's the first argument of the extension method and both the options classes have some common properties with the same types.

If HttpClient is used in .NET Framework it uses HttpWebRequest so we only need HttpWebRequestInstrumentationOptions. There is a possibility of someone using a .NET Core version of HttpClient in a .NET Framework application in which case we might need the HttpClientInstrumentationOptions but using HttpClient in that way is not recommended.

Changes

• Update AddHttpClientInstrumentation extension method for .NET Framework to only use HttpWebRequestInstrumentationOptions as an argument

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Changes in public API reviewed

[codecov]

Codecov Report

Merging #1982 (4e96d28) into main (6dfe944) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         192      192           
  Lines        6179     6179           
=======================================
  Hits         5182     5182           
  Misses        997      997           

Impacted Files	Coverage Δ
...umentation.Http/TracerProviderBuilderExtensions.cs	100.00% <ø> (ø)

[cijothomas]

Thanks! This looks good.

[alanwest]

I definitely think this improves things for usability in what we think is the most common case. Worst case if it does turn out that supporting configuring options for .NET Framework apps that consume the HttpClient nuget package is needed then maybe it could be a separate extension method.

[CodeBlanch]

LGTM

Might be worth noting in the docs for the instrumentation that HttpClient on .NET Framework uses HttpWebRequest internally and will fire HttpWebRequestInstrumentationOptions.Enrich\Filter callbacks.

[cijothomas]

The docs already call out difference between .NET FX and .NET Core cases. https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.Http#filter

[cijothomas]

The docs already call out difference between .NET FX and .NET Core cases. https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.Http#filter

I'll make it more clear that its .NET FX vs .NET Core, and not HttpClient vs HttpWebRequest and mention about the fact that HttpClient internally is HttpWebRequest in .NET Fx.