Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'en-us' from URLs #2329

Merged
merged 1 commit into from Sep 9, 2021
Merged

Remove 'en-us' from URLs #2329

merged 1 commit into from Sep 9, 2021

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Sep 9, 2021

Changes

  • Removes localization information from URLs so they will bring the clicker to the page of their appropriate language.
  • Verified that the URLs all still work properly after the change.

@mic-max mic-max requested a review from a team as a code owner September 9, 2021 18:04
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2329 (f25f0f5) into main (22b1ff5) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
+ Coverage   79.62%   79.67%   +0.05%     
==========================================
  Files         233      233              
  Lines        7346     7346              
==========================================
+ Hits         5849     5853       +4     
+ Misses       1497     1493       -4     
Impacted Files Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 70.65% <0.00%> (+2.17%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (+2.94%) ⬆️

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleanups!

@cijothomas cijothomas merged commit baa37f3 into open-telemetry:main Sep 9, 2021
@mic-max mic-max deleted the localized-urls branch September 28, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants