Use IsEnabled DS callback to filter out requests #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
|
@SergeyKanzhelev @austinlparker @discostu105 @bruno-garcia please review |
bruno-garcia
approved these changes
Oct 5, 2019
src/OpenTelemetry.Collector.Dependencies/DependenciesCollectorOptions.cs
Outdated
Show resolved
Hide resolved
…Options.cs Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>
lmolkova
commented
Oct 8, 2019
src/OpenTelemetry.Collector.AspNetCore/RequestsCollectorOptions.cs
Outdated
Show resolved
Hide resolved
austinlparker
approved these changes
Oct 8, 2019
This was referenced Oct 12, 2019
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
DiagnosticSource provides an efficient callback to prevent instrumentation for certain events.
We should use it instead of sampler/named tracer when possible to minimize perf impact on the application.
Now we need to filter out HTTP calls to exporters (AppInsights, Zipkin, not sure about LightStep).
Users may configure callback that will sample out certain requests - they write which ones.
Sampling happens too late and not the right mechanism to filter.
This change