Always generate a new metric stream for each view an instrument matches #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 84.75% 84.77% +0.02%
==========================================
Files 260 260
Lines 9273 9270 -3
==========================================
Hits 7859 7859
+ Misses 1414 1411 -3
|
alanwest
commented
Apr 7, 2022
Comment on lines
-142
to
+128
| if (!metrics.Contains(existingMetric)) | ||
| { | ||
| metrics.Add(existingMetric); | ||
| } | ||
|
|
||
| metrics.Add(existingMetric); |
There was a problem hiding this comment.
The conditional here is no longer required. Its purpose was to "merge" together identical streams resulting from different views. This primary purpose of this PR is to not do this merging.
alanwest
commented
Apr 7, 2022
cijothomas
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #3006 (comment)
Followups included in this PR:
Followups not included in this PR:
IStructuralEquatableFix bug with multiple views mapping to a single metric stream #3006 (comment)