Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public setter for MetricReaderOptions.PeriodicExportingMetricReaderOptions #3184

Merged
merged 5 commits into from
Apr 15, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest requested a review from a team as a code owner April 14, 2022 22:08
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #3184 (162650b) into main (c926c02) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
+ Coverage   84.87%   85.16%   +0.28%     
==========================================
  Files         259      259              
  Lines        9330     9330              
==========================================
+ Hits         7919     7946      +27     
+ Misses       1411     1384      -27     
Impacted Files Coverage Δ
...ry/Internal/PeriodicExportingMetricReaderHelper.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/MetricReaderOptions.cs 100.00% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.44% <0.00%> (+2.70%) ⬆️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 82.14% <0.00%> (+14.28%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+18.18%) ⬆️
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs 83.33% <0.00%> (+22.22%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+28.57%) ⬆️
...tation/ExportClient/OtlpGrpcMetricsExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@alanwest
Copy link
Member Author

alanwest commented Apr 14, 2022

Might have a flakey Prometheus test

From this run:

[xUnit.net 00:00:00.94]     OpenTelemetry.Exporter.Prometheus.Tests.PrometheusExporterHttpServerTests.PrometheusExporterHttpServerIntegration_NoMetrics [FAIL]
[xUnit.net 00:00:00.95]       System.Net.Http.HttpRequestException : Connection refused
[xUnit.net 00:00:00.95]       ---- System.Net.Sockets.SocketException : Connection refused
[xUnit.net 00:00:00.95]       Stack Trace:
[xUnit.net 00:00:00.95]            at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
[xUnit.net 00:00:00.95]            at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
[xUnit.net 00:00:00.95]         /home/runner/work/opentelemetry-dotnet/opentelemetry-dotnet/test/OpenTelemetry.Exporter.Prometheus.Tests/PrometheusExporterHttpServerTests.cs(159,0): at OpenTelemetry.Exporter.Prometheus.Tests.PrometheusExporterHttpServerTests.RunPrometheusExporterHttpServerIntegrationTest(Boolean skipMetrics)
[xUnit.net 00:00:00.95]         /home/runner/work/opentelemetry-dotnet/opentelemetry-dotnet/test/OpenTelemetry.Exporter.Prometheus.Tests/PrometheusExporterHttpServerTests.cs(42,0): at OpenTelemetry.Exporter.Prometheus.Tests.PrometheusExporterHttpServerTests.PrometheusExporterHttpServerIntegration_NoMetrics()
[xUnit.net 00:00:00.95]         --- End of stack trace from previous location where exception was thrown ---
[xUnit.net 00:00:00.95]         ----- Inner Stack Trace -----
[xUnit.net 00:00:00.95]            at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
  Failed OpenTelemetry.Exporter.Prometheus.Tests.PrometheusExporterHttpServerTests.PrometheusExporterHttpServerIntegration_NoMetrics [25 ms]

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a changelog is important as this is going to be stable release in a day!

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 73cc937 into open-telemetry:main Apr 15, 2022
@alanwest alanwest deleted the alanwest/public-setter branch September 30, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants