Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net5.0 from Zipkin and replace with net6.0 #3222

Merged

Conversation

cijothomas
Copy link
Member

Part of #3147

@cijothomas cijothomas requested a review from a team as a code owner April 22, 2022 05:07
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #3222 (f89f0f7) into main (11699a3) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   85.74%   85.44%   -0.30%     
==========================================
  Files         260      260              
  Lines        9366     9366              
==========================================
- Hits         8031     8003      -28     
- Misses       1335     1363      +28     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.42% <ø> (ø)
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 86.53% <0.00%> (-2.89%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 88.73% <0.00%> (-2.71%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 74.13% <0.00%> (-2.59%) ⬇️
...heus/Implementation/PrometheusCollectionManager.cs 79.74% <0.00%> (-2.54%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit e35216a into open-telemetry:main Apr 22, 2022
@cijothomas cijothomas deleted the cijothomas/zipkin_removenet50 branch April 22, 2022 15:09
@@ -1,15 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
<TargetFrameworks>net5.0;netstandard2.0;net462;</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.0;net462;</TargetFrameworks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas @alanwest @reyang @utpilla

Was just looking at this while investigating something else. It didn't occur to me at the time, but we kind of introduced an issue doing this.

Previously we had a net5.0 target and code like this:

#if NET5_0_OR_GREATER
                using var response = this.httpClient.Send(request, CancellationToken.None);
#else

That became:

#if NET6_0_OR_GREATER
                using var response = this.httpClient.Send(request, CancellationToken.None);
#else

Users on .NET 5 upgrading to latest will still compile, they will just bind to the netstandard2.1 target. However, they have lost the optimization. So for them, upgrading was a perf hit/carried unforeseen consequences.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Lesson is that in the future we need to align any drop of a target framework with the actual EOL date of the framework and consider which approach we're going to adopt here #3448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants